Fix: Prevent canvas resolution resizing if user passes in resolution values on canvas #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjtalbot
reviewed
Aug 10, 2022
| if (!heightProp) { | ||
| canvasRef.current.height = dpr * height; | ||
| } | ||
| canvasRef.current.style.width = width + 'px'; |
Contributor
There was a problem hiding this comment.
we still set the style to these new widths / heights?
mjtalbot
reviewed
Aug 10, 2022
| } | ||
|
|
||
| const { width, height } = getCanvasDimensions(); | ||
| const boundsChanged = |
Contributor
There was a problem hiding this comment.
updateBounds be called at all if we have width & height fixed?
avivian
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where someone's setting of width/height on the
RiveComponentfromuseRivedoesn't get overridden (brought up in Discord).This is setting
data-attributes on the canvas for user-passed in values for width/height resolutions as an indicator for us to see whether or not to override the width/height with our devicePixelRatio logic. This is because from the internals of the hook, we can't tell what user passed-in props (i.e width and/or height) are set on theRiveComponent, but we can look into the ref of the canvas element to check for these attributes.Definitely open to other ideas here; had to find a way to distinguish between us setting the width/height internally vs consumers setting it via props.