Attach res.doc to polyvariant #8155
Conversation
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e77f67f950
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
compiler/syntax/src/res_core.ml
Outdated
| let tag_with_doc = | ||
| match tag with | ||
| | Parsetree.Rtag (name, attrs, contains_constant, types) -> | ||
| Parsetree.Rtag | ||
| (name, doc_comment_attrs @ attrs, contains_constant, types) | ||
| | Rinherit _ -> tag |
There was a problem hiding this comment.
When a doc comment appears before a | that introduces an inherited row field (e.g., /** doc */ | Some.t), parse_tag_specs now accepts the comment but drops it because it only prepends doc_comment_attrs for Rtag and ignores Rinherit. That means the new syntax silently loses documentation in the AST and formatter. If doc comments are meant to attach to all polyvariant entries, you’ll want to carry doc_comment_attrs into the Rinherit case (e.g., by adding them to typ.ptyp_attributes or threading them into parse_tag_spec).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@codex can you give a concrete example of the above issue?
There was a problem hiding this comment.
To use Codex here, create a Codex account and connect to github.
|
@shulhi Could you address the comment from Codex? |
2 participants
Fix #8154