[AssertCompareToSpecificMethodRector ] Remove inversion of parameters in Assert calls #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! I've approved the CI to get feedback. Could you look at it? To fix this before pushing, run tests locally with |
VincentLanglet
force-pushed
the
issue/8942
branch
from
f9728c0 to
faf49a9
Compare
VincentLanglet
force-pushed
the
issue/8942
branch
from
faf49a9 to
733473a
Compare
Contributor
Author
It should be better now |
.../CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector/Fixture/get_class.php.inc
Outdated
Show resolved
Hide resolved
rules/CodeQuality/Rector/MethodCall/AssertCompareToSpecificMethodRector.php
Show resolved
Hide resolved
| public function test() | ||
| { | ||
| $this->assertCount(5, $something); | ||
| $this->assertSame(count($something), 5); |
Member
There was a problem hiding this comment.
Could you extract this to a new test fixture? It looks unrelated to change here.
By convention we separate files that have changes, and those that are skipped. So they're easier to read and test separately
Member
|
Perfect! Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.