[PHPUnit 10] Remove AssertIssetToAssertObjectHasPropertyRector

[samsonasik]

This rule is apply invalid transformation, since isset() is verify if property has null value as well, see https://3v4l.org/KBkr3

so the transformation is invalid.

For transform to assertObjectHasProperty, there is already configured config for that, see

rector-phpunit/config/sets/phpunit100.php

Lines 32 to 34 in 687747d

	// https://github.com/sebastianbergmann/phpunit/issues/5220
	new MethodCallRename('PHPUnit\Framework\Assert', 'assertObjectHasAttribute', 'assertObjectHasProperty'),
	new MethodCallRename('PHPUnit\Framework\Assert', 'assertObjectNotHasAttribute', 'assertObjectNotHasProperty'),

which transformable from AssertPropertyExistsRector rule for that, see

rector-phpunit/rules/CodeQuality/Rector/MethodCall/AssertPropertyExistsRector.php

Line 23 in 687747d

final class AssertPropertyExistsRector extends AbstractRector

rector-phpunit/rules-tests/CodeQuality/Rector/MethodCall/AssertPropertyExistsRector/Fixture/fixture2.php.inc

Lines 5 to 27 in 687747d

	final class MyTest2 extends \PHPUnit\Framework\TestCase
	{
	public function test()
	{
	$response = new \Namespaced\Response();
	$this->assertFalse(property_exists($response, 'property'));
	}
	}
	?>
	-----
	<?php
	namespace Rector\PHPUnit\Tests\CodeQuality\Rector\MethodCall\AssertPropertyExistsRector\Fixture;
	final class MyTest2 extends \PHPUnit\Framework\TestCase
	{
	public function test()
	{
	$response = new \Namespaced\Response();
	$this->assertObjectNotHasAttribute('property', $response);
	}
	}

so combine them will apply the syntax transformation.

[samsonasik]

@TomasVotruba Ready to merge 👍

[TomasVotruba]

Makes sense, thank you ☺️