Remove invalid React Compiler expectedErrors annotations #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes expectedErrors metadata from code block fences that
were incorrectly added during the sync process. These annotations
(e.g., {expectedErrors: {'react-compiler': [5]}}) were meant to document
expected compiler diagnostics, but the React Compiler is not actually
reporting errors on those lines.
The upstream English react.dev repository does not have these annotations
either, confirming they should not be present in the Bengali translation.
Changes made:
- Ran `yarn lint:fix` to auto-fix all expectedErrors mismatches
- 34 markdown files updated (79 lines changed)
- Only code fence metadata modified - no translation content affected
- All Bengali translations remain completely intact
This fixes the site_lint CI check that was failing due to:
"React Compiler expected error on line X was not triggered"
The ESLint local rules plugin validates that expectedErrors annotations
match actual compiler diagnostics. When errors aren't triggered, the
annotations are automatically removed to maintain accuracy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes expectedErrors metadata from code block fences that were incorrectly added during the sync process. These annotations (e.g., {expectedErrors: {'react-compiler': [5]}}) were meant to document expected compiler diagnostics, but the React Compiler is not actually reporting errors on those lines.
The upstream English react.dev repository does not have these annotations either, confirming they should not be present in the Bengali translation.
Changes made:
yarn lint:fixto auto-fix all expectedErrors mismatchesThis fixes the site_lint CI check that was failing due to: "React Compiler expected error on line X was not triggered"
The ESLint local rules plugin validates that expectedErrors annotations match actual compiler diagnostics. When errors aren't triggered, the annotations are automatically removed to maintain accuracy.