Skip to content

Missing crosstype arithmetic #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnsiemer merged 3 commits into from
Dec 23, 2025
Merged

Missing crosstype arithmetic #520

jnsiemer merged 3 commits into from
Dec 23, 2025

Conversation

@jnsiemer
Copy link
Member

@jnsiemer jnsiemer commented Dec 21, 2025

Description

This PR ensures that...

  • any reasonable integer type * floating-point arithmetic is implemented,
  • any reasonable integer type * Zq is implemented.

Testing

  • I added basic working examples (possibly in doc-comment)
  • I added tests for large (pointer representation) values
  • I triggered all possible errors in my test in every possible way
  • I included tests for all reasonable edge cases

Checklist:

  • I have performed a self-review of my own code
    • The code provides good readability and maintainability s.t. it fulfills best practices like talking code, modularity, ...
      • The chosen implementation is not more complex than it has to be
    • My code should work as intended and no side effects occur (e.g. memory leaks)
    • The doc comments fit our style guide

@jnsiemer jnsiemer self-assigned this Dec 21, 2025
3pmile
3pmile approved these changes Dec 22, 2025
View reviewed changes
src/integer/mat_z/arithmetic/mul_scalar.rs
let mat_1 = MatZ::from_str("[[2, 1],[1, 2]]").unwrap();
let mat_2 = mat_1.clone();
let mat_3 = MatZq::from_str("[[2, 1],[1, 2]] mod 3").unwrap();
let zq = Zq::from((1, 3));
Copy link
Member

@3pmile 3pmile Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also, check with another value than 1 (mod 3)

@jnsiemer jnsiemer merged commit 67220af into dev Dec 23, 2025
2 checks passed
@jnsiemer jnsiemer deleted the missing_crosstype_arithmetic branch December 23, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@3pmile 3pmile 3pmile approved these changes

@Marvin-Beckmann Marvin-Beckmann Awaiting requested review from Marvin-Beckmann

Assignees

@jnsiemer jnsiemer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnsiemer @3pmile