AdjustBrightness/Contrast/Hue/Saturation CV-CUDA Backend #9297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/9297
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 4 New Failures, 1 Unrelated FailureAs of commit 13f6e7c with merge base aa35ca1 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
justincdavis
changed the title
justincdavis
changed the title
justincdavis
force-pushed
the
brightness_contrast_hue_cvcuda
branch
from
efef692 to
8564f0a
Compare
zy1git
reviewed
Jan 5, 2026
Contributor
zy1git
left a comment
zy1git
left a comment
There was a problem hiding this comment.
I left some comments for the first round review. Feel free to let me know your thoughts.
| assert mae < 2 | ||
| mae_threshold = 2 | ||
| if make_input is make_image_cvcuda: | ||
| mae_threshold = 3 |
Contributor
There was a problem hiding this comment.
May I know why the threshold becomes 3 here?
| rgb = cvcuda.cvtcolor(hsv_modified, cvcuda.ColorConversion.HSV2RGB) | ||
|
|
||
| if fp: | ||
| rgb = cvcuda.convertto(rgb, cvcuda.Type.F32, scale=256.0 - 1e-3, offset=0.0) |
Contributor
There was a problem hiding this comment.
What is the reason for using "256.0 - 1e-3" as the scale?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
adjust_brightness,adjust_contrast,adjust_hue, and 'adjust_saturation' CV-CUDA kernelsTesting
python3 -m pytest test/test_transforms_v2.py::TestAdjustBrightnesspython3 -m pytest test/test_transforms_v2.py::TestAdjustContrastpython3 -m pytest test/test_transforms_v2.py::TestAdjustHuepython3 -m pytest test/test_transforms_v2.py::TestAdjustSaturationpython3 -m pytest test/test_transforms_v2.py::TestColorJitter