Skip to content

Conversation

@psiddh
Copy link
Contributor

@psiddh psiddh commented Jan 5, 2026

Summary:
D90093073 introduced an eps parameter to PTQ quantization config functions but missed adding it to the QAT equivalents (get_8a8w_qnn_qat_config, get_16a4w_qnn_qat_config, get_qat_per_channel_quant_config). This caused test_qnn_backend_linear_qat to fail because ModuleQConfig.__post_init__ now passes eps=self.eps to all config functions, but the QAT functions didn't accept this parameter.

This change adds the eps parameter to these QAT config functions and properly applies it to all observers (activation, weight, and bias) to maintain consistency with the PTQ functions.

Reviewed By: SS-JIA

Differential Revision: D90123723

cc @cccclai @winskuo-quic @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin

Summary:
D90093073 introduced an `eps` parameter to PTQ quantization config functions but missed adding it to the QAT equivalents (`get_8a8w_qnn_qat_config`, `get_16a4w_qnn_qat_config`, `get_qat_per_channel_quant_config`). This caused `test_qnn_backend_linear_qat` to fail because `ModuleQConfig.__post_init__` now passes `eps=self.eps` to all config functions, but the QAT functions didn't accept this parameter.

This change adds the `eps` parameter to these QAT config functions and properly applies it to all observers (activation, weight, and bias) to maintain consistency with the PTQ functions.

Reviewed By: SS-JIA

Differential Revision: D90123723
@psiddh psiddh requested a review from cccclai as a code owner January 5, 2026 19:48
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16458

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (2 Unrelated Failures)

As of commit 20554fc with merge base 419427c (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@meta-codesync
Copy link

meta-codesync bot commented Jan 5, 2026

@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90123723.

Copy link
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review automatically exported from Phabricator review in Meta.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin added partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ labels Jan 5, 2026
@psiddh psiddh merged commit 0da0812 into pytorch:main Jan 5, 2026
163 of 176 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ partner: qualcomm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Qualcomm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants