Add eps parameter to QAT quantization config functions #16458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
D90093073 introduced an
epsparameter to PTQ quantization config functions but missed adding it to the QAT equivalents (get_8a8w_qnn_qat_config,get_16a4w_qnn_qat_config,get_qat_per_channel_quant_config). This causedtest_qnn_backend_linear_qatto fail becauseModuleQConfig.__post_init__now passeseps=self.epsto all config functions, but the QAT functions didn't accept this parameter.This change adds the
epsparameter to these QAT config functions and properly applies it to all observers (activation, weight, and bias) to maintain consistency with the PTQ functions.Reviewed By: SS-JIA
Differential Revision: D90123723
cc @cccclai @winskuo-quic @shewu-quic @haowhsu-quic @DannyYuyang-quic @cbilgin