[slimtensor] Add all required dtype support (Int8/16/32/64, Bool, BFloat16) #16399
+538
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oat16) This diff adds support for all required scalar types in SlimTensor to support ExecuTorch aoti-driven backend usage: Int8 (Char), Int16 (Short), Int32 (Int), Int64 (Long), Bool, and BFloat16. **Key changes:** 1. **`c10/core/ScalarType.h`** - Extended with all required types: - Added enum values matching PyTorch's c10::ScalarType for compatibility - Added type alias constants (kChar, kShort, kInt, kLong, kBool, kBFloat16) - Extended `elementSize()` to return correct sizes for all types - Extended `toString()` for all types - Fixed `isFloatingType()` to include BFloat16 - Fixed `isIntegralType()` to properly handle all integral types and Bool - Added `isBoolType()` helper function - Imported BFloat16 from ExecuTorch's portable_type Differential Revision: [D89821402](https://our.internmc.facebook.com/intern/diff/D89821402/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16399
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New Failures, 3 Unrelated FailuresAs of commit 368f131 with merge base fd6fa87 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 26, 2025
Gasoonjia
added a commit
that referenced
this pull request
Dec 26, 2025
…oat16) This diff adds support for all required scalar types in SlimTensor to support ExecuTorch aoti-driven backend usage: Int8 (Char), Int16 (Short), Int32 (Int), Int64 (Long), Bool, and BFloat16. **Key changes:** 1. **`c10/core/ScalarType.h`** - Extended with all required types: - Added enum values matching PyTorch's c10::ScalarType for compatibility - Added type alias constants (kChar, kShort, kInt, kLong, kBool, kBFloat16) - Extended `elementSize()` to return correct sizes for all types - Extended `toString()` for all types - Fixed `isFloatingType()` to include BFloat16 - Fixed `isIntegralType()` to properly handle all integral types and Bool - Added `isBoolType()` helper function - Imported BFloat16 from ExecuTorch's portable_type Differential Revision: [D89821402](https://our.internmc.facebook.com/intern/diff/D89821402/) ghstack-source-id: 331195238 Pull Request resolved: #16399
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
…, Bool, BFloat16)" This diff adds support for all required scalar types in SlimTensor to support ExecuTorch aoti-driven backend usage: Int8 (Char), Int16 (Short), Int32 (Int), Int64 (Long), Bool, and BFloat16. **Key changes:** 1. **`c10/core/ScalarType.h`** - Extended with all required types: - Added enum values matching PyTorch's c10::ScalarType for compatibility - Added type alias constants (kChar, kShort, kInt, kLong, kBool, kBFloat16) - Extended `elementSize()` to return correct sizes for all types - Extended `toString()` for all types - Fixed `isFloatingType()` to include BFloat16 - Fixed `isIntegralType()` to properly handle all integral types and Bool - Added `isBoolType()` helper function - Imported BFloat16 from ExecuTorch's portable_type Differential Revision: [D89821402](https://our.internmc.facebook.com/intern/diff/D89821402/) [ghstack-poisoned]
This was referenced Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds support for all required scalar types in SlimTensor to support ExecuTorch aoti-driven backend usage: Int8 (Char), Int16 (Short), Int32 (Int), Int64 (Long), Bool, and BFloat16.
Key changes:
c10/core/ScalarType.h- Extended with all required types:elementSize()to return correct sizes for all typestoString()for all typesisFloatingType()to include BFloat16isIntegralType()to properly handle all integral types and BoolisBoolType()helper functionDifferential Revision: D89821402