Fix dynamic shape missing Symbol errors #16390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16390
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New Failure, 8 Pending, 1 Unrelated FailureAs of commit c6440a7 with merge base 31ec75e ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
derekxu
pushed a commit
to derekxu/executorch
that referenced
this pull request
Dec 26, 2025
Summary: More context in https://fb.workplace.com/groups/pytorch.edge.users/permalink/1941980700005547/ Differential Revision: D89754133
derekxu
force-pushed
the
export-D89754133
branch
2 times, most recently
from
9a4cb8e to
dbda7d1
Compare
derekxu
pushed a commit
to derekxu/executorch
that referenced
this pull request
Dec 30, 2025
Summary: More context in https://fb.workplace.com/groups/pytorch.edge.users/permalink/1941980700005547/ Differential Revision: D89754133
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
kimishpatel
approved these changes
Dec 30, 2025
psiddh
approved these changes
Dec 30, 2025
derekxu
pushed a commit
to derekxu/executorch
that referenced
this pull request
Dec 30, 2025
Summary:
Handle edge case of the range constraints of mixed Symbol + int where the replacement does not have the key.
E.g. {s11: VR[2, 32], s11 + 2048: VR[2050, 2080]}
The replacements only have key "s11" due to "s11 + 2048" is merged to s11. This is needed to the StaticAttention attention class that the attention mask append the dynamic seq_len at the last dimension.
Dynamic shapes and mixed symbol are required for the CoreML enumerated shapes as the precursor for ET enabled CoreML enumerated shape
Reviewed By: kimishpatel
Differential Revision: D89754133
derekxu
force-pushed
the
export-D89754133
branch
from
dbda7d1 to
b847301
Compare
Summary:
Handle edge case of the range constraints of mixed Symbol + int where the replacement does not have the key.
E.g. {s11: VR[2, 32], s11 + 2048: VR[2050, 2080]}
The replacements only have key "s11" due to "s11 + 2048" is merged to s11. This is needed to the StaticAttention attention class that the attention mask append the dynamic seq_len at the last dimension.
Dynamic shapes and mixed symbol are required for the CoreML enumerated shapes as the precursor for ET enabled CoreML enumerated shape
Reviewed By: kimishpatel
Differential Revision: D89754133
derekxu
force-pushed
the
export-D89754133
branch
from
b847301 to
c6440a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle edge case of the range constraints of mixed Symbol + int where the replacement does not have the key.
E.g. {s11: VR[2, 32], s11 + 2048: VR[2050, 2080]}
The replacements only have key "s11" due to "s11 + 2048" is merged to s11. This is needed to the StaticAttention attention class that the attention mask append the dynamic seq_len at the last dimension.
Dynamic shapes and mixed symbol are required for the CoreML enumerated shapes as the precursor for ET enabled CoreML enumerated shape
Differential Revision: D89754133