[xmltodict] Fix false positive for namespaces with None values #15245
+11
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
This comment has been minimized.
This comment has been minimized.
donbarbos
reviewed
Jan 10, 2026
Contributor
donbarbos
left a comment
donbarbos
left a comment
There was a problem hiding this comment.
Thank you! In this case, Mapping[str, str | None] should be sufficient, and the _Namespaces type alias seems unnecessary. Using a single Mapping would improve clarity and consistency:
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Contributor
Author
|
@donbarbos Good point, updated. Thanks for the review! |
donbarbos
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
The namespaces parameter in
xmltodict.parse()andunparse()now acceptsNonevalues, which are used to skip namespaces according to thexmltodictdocumentation. Previously, passingdict[str, None]caused a type error even though it's valid at runtime. Fixes #15165.