gh-143394: filter for turning off automatic margins in test_no_newline #143433

chris-eibl · 2026-01-05T11:25:21Z

@smontanaro This should fix your issue.

Sorry, I cannot test because I have no Mac.

Also, I don't know why CI and buildbots did not complain before, see

Lines 390 to 391 in 68fcb95

    
           if self.is_apple_terminal: 
        
               os.write(self.output_fd, b"\033[?7h")

cpython/Lib/_pyrepl/unix_console.py

Lines 166 to 168 in 68fcb95

    
           self.is_apple_terminal = ( 
        
               platform.system() == "Darwin" 
        
               and os.getenv("TERM_PROGRAM") == "Apple_Terminal"

Issue: test_pyrepl failure on main #143394

chris-eibl · 2026-01-05T11:27:59Z

Lib/test/test_pyrepl/test_pyrepl.py

            safe_patterns.append(r'\x1b\[\?12[hl]')  # cursor blinking

+        # rmam - turn off automatic margins
+        rmam = ti.get("rmam")


I've taken rmam from https://man7.org/linux/man-pages/man5/terminfo.5.html.

@ambv Should I add

enter_am_mode smam SA turn on automatic margins

as well?

Yes, please.

Chris, this didn't fail because the terminfo database can be different between computers depending on where you got it. I've seen IDEs override it, too, to work around issues with their custom built-in terminal emulators. Finally, while (almost) nobody does that, technically the terminfo database is user-editable and even allows addition of custom user-defined capabilities. So we'll likely have to do some whackamole with stuff we missed for a time, but that's alright. I had the same worry with replacing ncurses with a hand-rolled terminfo parser, but so far, so good. The only report we got so far there was from NetBSD.

FWIW, my setup is a stock MacOS Tahoe (26.2) running on an M1 MacBook Pro. I don't do framework builds. Tests are run in a normal MacOS Terminal app with TERM defined as xterm256color. While I refer to TERM in my various shell startup files, I do not change its value, nor do I see a file in /etc containing TERM.

Are the Mac buildbots testing framework builds? If so, what kind of terminal environment exists there? Perhaps the pyrepl tests should be run a few times with different (common?) values for TERM.

Chris, this didn't fail because the terminfo database can be different between computers depending on [...]

Thank you for the detailed explanation ❤️

Yet, I do not understand why e.g. CI passed previous to this PR. We didn't do any filtering regarding \033[?7h before, but CI passed. I assume, because in CI and for our build bots is_apple_terminal is false, but obviously on @smontanaro's setup it returns true.

Setting is_apple_terminal manually to true immediately raised the problem for me on WSL and native Ubuntu ...

This is the culprit, @chris-eibl: the Apple Terminal special case. I'll make sure to test that, too, when landing stuff. We can also look into running the main test_pyrepl stuff twice, the second time with is_apple_terminal mocked to return True. That way we won't regress in the future.

As someone who uses a Mac daily, are there changes to my environment I can make to mimic the environment of the Mac buildbots? I'm happy to add that to my mix. I routinely run tests for main and the two most recent older branches (currently 3.13 & 3.14).

Most probably is_apple_terminal is false on CI, because os.getenv("TERM_PROGRAM") == "Apple_Terminal" does not evaluate to true there, but idk why :(

At least #143461 takes care to enforce Apple_Terminal, so your use case is now handled, too.

You can set TERM_PROGRAM to something different than Apple_Terminal to mimic what happened in CI.

You can set TERM_PROGRAM to something different than Apple_Terminal to mimic what happened in CI.

Excellent, I can just run in an xterm. (Hadn't occurred to me before, but then I didn't realize there were these kinds of environment diffs.)

ambv · 2026-01-05T21:45:58Z

I reproduced the problem with Apple Terminal and can confirm this PR fixes it.

miss-islington-app · 2026-01-05T21:47:14Z

Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…newline (pythonGH-143433) (cherry picked from commit 04ace41) Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

bedevere-app · 2026-01-05T21:47:22Z

GH-143459 is a backport of this pull request to the 3.14 branch.

…_newline (GH-143433) (GH-143459) (cherry picked from commit 04ace41) Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

miss-islington-app · 2026-01-06T13:45:14Z

Thanks @chris-eibl for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…newline (pythonGH-143433) (cherry picked from commit 04ace41) Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com>

bedevere-app · 2026-01-06T13:45:28Z

GH-143478 is a backport of this pull request to the 3.13 branch.

…_newline (GH-143433) (GH-143478) Co-authored-by: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl>

filter for turning off automatic margins in test_no_newline

d164877

chris-eibl requested review from ambv, lysnikolaou and pablogsal as code owners January 5, 2026 11:25

bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jan 5, 2026

bedevere-app bot mentioned this pull request Jan 5, 2026

test_pyrepl failure on main #143394

Closed

chris-eibl added the skip news label Jan 5, 2026

chris-eibl commented Jan 5, 2026

View reviewed changes

add smam

5017cc2

ambv merged commit 04ace41 into python:main Jan 5, 2026
44 checks passed

bedevere-app bot removed the awaiting review label Jan 5, 2026

ambv added the needs backport to 3.14 bugs and security fixes label Jan 5, 2026

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 5, 2026

chris-eibl added the needs backport to 3.13 bugs and security fixes label Jan 6, 2026

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2026

chris-eibl deleted the fix-test_no_newline branch January 7, 2026 06:51

	if self.is_apple_terminal:
	os.write(self.output_fd, b"\033[?7h")

	self.is_apple_terminal = (
	platform.system() == "Darwin"
	and os.getenv("TERM_PROGRAM") == "Apple_Terminal"

Uh oh!

gh-143394: filter for turning off automatic margins in test_no_newline #143433

gh-143394: filter for turning off automatic margins in test_no_newline #143433

Uh oh!

Conversation

chris-eibl commented Jan 5, 2026 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ambv commented Jan 5, 2026

Uh oh!

Uh oh!

miss-islington-app bot commented Jan 5, 2026

Uh oh!

bedevere-app bot commented Jan 5, 2026

Uh oh!

miss-islington-app bot commented Jan 6, 2026

Uh oh!

bedevere-app bot commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chris-eibl commented Jan 5, 2026 •

edited by bedevere-app bot

Loading