gh-143308: fix UAF when PickleBuffer is concurrently mutated in a callback #143312
+54
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Dec 31, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-12-31-17-38-33.gh-issue-143308.lY8UCR.rst
Outdated
Show resolved
Hide resolved
picnixz
reviewed
Dec 31, 2025
picnixz
reviewed
Dec 31, 2025
picnixz
reviewed
Dec 31, 2025
picnixz
reviewed
Dec 31, 2025
picnixz
changed the title
picnixz
previously approved these changes
Dec 31, 2025
Member
|
Just a small thing to alter and we're good (good to keep a clickable ref) |
picnixz
added
needs backport to 3.14
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Dec 31, 2025
picnixz
dismissed
their stale review
Waiting until the NEWS entry has been moved.
picnixz
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a use-after-free vulnerability in
save_picklebufferinModules/_pickle.c. The issue occurred when a buffer_callback explicitly released the PickleBuffer while the pickler was still serializing it.Validation
test_release_in_callback_keepaliveandtest_release_in_callback_complex_keepalivetoLib/test/test_pickle.py.Linked issue: gh-128038
save_picklebuffervia re-entrantbuffer_callbackand__bool__#143308