gh-140025: Fix queue.SimpleQueue.__sizeof__()

[Aniketsy]

• Update SimpleQueue.sizeof() to include the memory used by its internal buffer.
• add a unit test.

Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou !

• Issue: queue.SimpleQueue.__sizeof__() ignores the underlying data structure #140025

[colesbury]

A few comments below. Please also add a blurb

[colesbury]

This needs a critical section (a lock for the queue). The simplest way is to use "Argument Clinic" like the other functions.

Something like:

/*[clinic input]
@critical_section
_queue.SimpleQueue.__sizeof__ -> Py_ssize_t

Returns size in memory, in bytes.
[clinic start generated code]*/

static Py_ssize_t
simplequeue_sizeof_impl(simplequeueobject *self)
/*[clinic end generated code: output=3303f008eaa6a0a5 input=9b51620c76fc4507]*/

Then run make clinic to regenerate the bindings.

[colesbury]

You'll also need to change this to use the Argument Clinic methoddef (like above).

[colesbury]

A few changes:

1. Don't use ctypes (no support for that in wasi)
2. Use support.calcobjsize
3. Use sys.getsizeof() instead of calling __sizeof__ directly

[Aniketsy]

@colesbury thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.

[picnixz]

thanks for the feedback. i've applied changes as per suggestions, please let me know if this needs further improvement.

Please make it so that the CI is green before requesting a new review.

[Aniketsy]

@picnixz ci is now green. @colesbury could you please review now if you get a chance. Thanks!

[colesbury]

Thanks a few comments below

[colesbury]

Move import sys up between import random and import threading

[Aniketsy]

sure, I missed that. I thought running pre-commit run would take care of it.

[picnixz]

Can you put the definition of this method after the definition of qsize please?

[Aniketsy]

Sure, I’ll update this.

[bedevere-bot]

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit f3e069a.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/13136) and take a look at the build logs.
4. Check if the failure is related to this commit (f3e069a) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/13136

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=13 mode='wb' closefd=True>


Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 946, in gc_collect
    gc.collect()
    ~~~~~~~~~~^^
ResourceWarning: unclosed file <_io.FileIO name=11 mode='wb' closefd=True>