Skip to content

Conversation

@REDxEYE
Copy link
Contributor

@REDxEYE REDxEYE commented Aug 7, 2022

This pull request adds initial support for VTF image format

Changes proposed in this pull request:

  • Add support for Valve Texture Format images

@REDxEYE REDxEYE changed the title Initial VTF read support Initial VTF support Aug 7, 2022
@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 7, 2022

Can I provide arguments to save the function? Like compression mode, flags and etc?

@radarhere
Copy link
Member

Like im.save("out.vtf", compression=...)? Yes. Those arguments will become part of the im.encoderinfo dictionary.

@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 8, 2022

Yes, that's just what I needed, thanks!

@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 9, 2022

@radarhere Do I need to encode the image row-by-row or i can go like 4 rows at once because Bcn works in blocks of 4 by 4 pixels?
I never worked with Pillow C API, so i need some help

@radarhere
Copy link
Member

@radarhere Do I need to encode the image row-by-row or i can go like 4 rows at once because Bcn works in blocks of 4 by 4 pixels? I never worked with Pillow C API, so i need some help

No, you don't have to.

A while ago, I attempted to implement DXT1 encoding. You might find that helpful - radarhere@363fab4

@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 10, 2022

I see, your attempt is quite close to what I wrote, but I used a different way to get 2 main colors for the block. Can I reuse some of your code from 363fab4?

@radarhere
Copy link
Member

Feel free

@REDxEYE REDxEYE requested a review from radarhere August 12, 2022 00:17
@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 12, 2022

@radarhere Can you please review my bcn encoder?

@radarhere
Copy link
Member

radarhere commented Aug 12, 2022

Slightly confused - this PR is still a draft, but you'd like a review?

Also, your lint problems could be resolved by just using the black formatting - REDxEYE#2. Is there a particular part of the styling that you dislike?

@REDxEYE
Copy link
Contributor Author

REDxEYE commented Aug 12, 2022

Slightly confused - this PR is still a draft, but you'd like a review?

Also, your lint problems could be resolved by just using the black formatting - REDxEYE#2. Is there a particular part of the styling that you dislike?

I'm asking for a encoder code review, pr itself not even close to be ready :)

@REDxEYE REDxEYE marked this pull request as ready for review August 24, 2022 18:08
REDxEYE and others added 2 commits May 5, 2025 00:31
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@radarhere
Copy link
Member

All of the test images you've included are able to be distributed as part of Pillow under our license, yes?

@REDxEYE
Copy link
Contributor Author

REDxEYE commented May 6, 2025

Yes, these are test images i created myself, so they are non-copyrighted

@radarhere
Copy link
Member

I've created REDxEYE#11 with some suggestions.

REDxEYE and others added 4 commits May 31, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants