Skip to content

Pluralization bug with Duration.in_words() #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashb merged 7 commits into from
Jul 17, 2025
Merged

Pluralization bug with Duration.in_words() #826

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9965d91
Fixed pluralization in test
May 20, 2024
c24d12e
Added test for extra decimal places for subsecond strings
May 20, 2024
b1b3577
Fixed pluralization bug and added arbitrary decimal places on subseconds
May 20, 2024
231cdae
Update src/pendulum/duration.py
Solipsistmonkey May 20, 2024
14dec35
Apply suggestions from code review
ashb Jul 16, 2025
80d4b82
Apply suggestions from code review
ashb Jul 16, 2025
f454f09
Update src/pendulum/duration.py
ashb Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pendulum/duration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ def in_minutes(self) -> int:
def in_seconds(self) -> int:
return int(self.total_seconds())

def in_words(self, locale: str | None = None, separator: str = " ") -> str:
def in_words(self, locale: str | None = None, separator: str = " ") -> str:
"""
Get the current interval in words in the current locale.

Expand Down Expand Up @@ -273,8 +273,8 @@ def in_words(self, locale: str | None = None, separator: str = " ") -> str:

if not parts:
count: int | str = 0
if abs(self.microseconds) > 0:
unit = f"units.second.{loaded_locale.plural(1)}"
if self.microseconds != 0:
unit = f"units.second.{loaded_locale.plural(0)}"
count = f"{abs(self.microseconds) / 1e6:.2f}"
else:
unit = f"units.microsecond.{loaded_locale.plural(0)}"
Expand Down
3 changes: 1 addition & 2 deletions tests/duration/test_in_words.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,11 @@ def test_separator():
def test_subseconds():
pi = pendulum.duration(microseconds=123456)

assert pi.in_words() == "0.12 second"
assert pi.in_words() == "0.12 seconds"


def test_subseconds_with_seconds():
pi = pendulum.duration(seconds=12, microseconds=123456)

assert pi.in_words() == "12 seconds"


Expand Down
Loading