-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Fix prepare-release-pr script #13263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The script is [currently failing with](https://github.com/pytest-dev/pytest/actions/runs/13615071695/job/38057071681): ``` remote: Support for password authentication was removed on August 13, 2021. remote: Please see https://docs.github.com/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls for information on currently recommended modes of authentication. fatal: Authentication failed for 'https://github.com/pytest-dev/pytest.git/' ``` Decided to remove the usage of `github3` and use the `gh` command-line tool directly, which simplifies the script, integrates nicely with GH, and enables to run it locally seamlessly.
db85ff2 to
79f0733
Compare
|
🎉 #13264 |
RonnyPfannschmidt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the way this script develops - i wonder if it wouldn't make sense to just turn it into a workflow later on
Backport to 8.3.x: 💚 backport PR created✅ Backport PR branch: Backported as #13295 🤖 @patchback |
Fix prepare-release-pr script (cherry picked from commit ec87085)
Fix prepare-release-pr script (cherry picked from commit ec87085) Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
The script is currently failing with:
Decided to remove the usage of
github3and use theghcommand-line tool directly, which simplifies the script, integrates nicely with GH, and enables to run it locally seamlessly.