Fix flux-pmix version for integration tests #880
Conversation
📝 WalkthroughWalkthroughUpdated the h5py dependency version from 3.15.1 to 3.15.0 in the CI support environment configuration file. This is a single-line version adjustment to the integration test environment specification. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.ci_support/environment-integration.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.12)
- GitHub Check: unittest_openmpi (ubuntu-24.04-arm, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.11)
- GitHub Check: unittest_mpich (ubuntu-22.04-arm, 3.13)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.12)
- GitHub Check: unittest_win
- GitHub Check: unittest_mpich (macos-latest, 3.13)
- GitHub Check: unittest_mpich (ubuntu-24.04-arm, 3.13)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.11)
- GitHub Check: unittest_openmpi (ubuntu-22.04-arm, 3.13)
- GitHub Check: unittest_old
- GitHub Check: unittest_openmpi (macos-latest, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.13)
- GitHub Check: unittest_slurm_mpich
- GitHub Check: unittest_flux_mpich
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
- GitHub Check: unittest_flux_openmpi
- GitHub Check: notebooks
| - conda-forge | ||
| dependencies: | ||
| - h5py =3.15.1 | ||
| - h5py =3.15.0 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
h5py 3.15.1 issues bugs compatibility problems
💡 Result:
Brief summary of known issues / compatibility notes for h5py 3.15.1:
-
Python and HDF5 compatibility: h5py 3.15.x requires Python ≥3.10 and raises the minimum supported HDF5 versions (minimum 1.10.7, and 1.12.1+ within the 1.12 series). Build-time Cython/numpy requirements were updated. [1]
-
Free-threading / Python runtime: work to support CPython’s free-threaded mode is in progress but not fully tested; some incompatibilities remain. If you depend on free-threading you may encounter issues. [1]
-
macOS wheel regression fixed: the 3.15.1 bugfix release restored pre-built macOS wheels compatibility back to older macOS (Big Sur / 11.0 for ARM, 10.15 for Intel), which also resolved some mysterious macOS regressions in earlier 3.15 builds. This only applies to PyPI-provided packages. [2]
-
Reported runtime issues in the wild: there are active GitHub issues (e.g., problems with dimension scales and some wheels/HDF5 interactions) reported by users when combining certain HDF5 versions, platform wheels, or newer numpy versions — these are being tracked on the project issue tracker. If you hit runtime errors (esp. around dimension scales, vlen/compound types, or wheel vs system-HDF5 mismatches) check/raise an issue with full h5py.version.info and environment details. [3]
Recommendations:
- If you need maximum stability, build h5py from source against a known-good HDF5 on your platform, or pin to a h5py/HDF5 combination that you’ve tested.
- When filing bugs, include h5py.version.info, HDF5 and numpy versions, Python version, platform, and a minimal repro. [3]
Sources: h5py 3.15 “What’s New” and 3.15.1 notes; h5py GitHub issue tracker. [1][2][3]
References
[1] h5py 3.15 “What’s new” documentation.
[2] h5py 3.15.1 bug-fix release notes (macOS wheel fix).
[3] Example GitHub issue reporting dimension-scale / wheel/HDF5 problems.
🏁 Script executed:
#!/bin/bash
# Check conda-forge for h5py version availability
curl -s "https://conda.anaconda.org/conda-forge/linux-64/repodata.json.bz2" 2>/dev/null | bunzip2 | jq -r '.packages | keys[] | select(startswith("h5py"))' | head -20Repository: pyiron/executorlib
Length of output: 107
🏁 Script executed:
#!/bin/bash
# Check PyPI for h5py 3.15.0 availability
curl -s "https://pypi.org/pypi/h5py/json" | python3 << 'EOF'
import json, sys
data = json.load(sys.stdin)
versions = list(data['releases'].keys())
print("h5py 3.15.0 available:", "3.15.0" in versions)
print("h5py 3.15.1 available:", "3.15.1" in versions)
if "3.15.0" in versions and "3.15.1" in versions:
v315_0_date = data['releases']['3.15.0'][0].get('upload_time_iso_8601', 'unknown')
v315_1_date = data['releases']['3.15.1'][0].get('upload_time_iso_8601', 'unknown')
print(f"3.15.0 released: {v315_0_date}")
print(f"3.15.1 released: {v315_1_date}")
EOFRepository: pyiron/executorlib
Length of output: 782
🏁 Script executed:
#!/bin/bash
# Search conda-forge channel info for h5py versions
curl -s "https://conda.anaconda.org/conda-forge/noarch/repodata.json" 2>/dev/null | python3 << 'EOF'
import json, sys
try:
data = json.load(sys.stdin)
h5py_pkgs = {k: v for k, v in data.get('packages', {}).items() if 'h5py' in k}
print("Conda-forge search produced results:", len(h5py_pkgs) > 0)
except Exception as e:
print(f"Could not parse conda repodata: {e}")
EOFRepository: pyiron/executorlib
Length of output: 135
🏁 Script executed:
#!/bin/bash
# Check git history for this file
git log --oneline -10 -- .ci_support/environment-integration.yml 2>/dev/null || echo "Git history unavailable"Repository: pyiron/executorlib
Length of output: 104
🏁 Script executed:
#!/bin/bash
# Check if there are any references to h5py issues or downgrade in comments/issues
rg -i "h5py.*3\.15\.(0|1)" --type md --type txt --type yaml 2>/dev/null | head -20Repository: pyiron/executorlib
Length of output: 99
🏁 Script executed:
#!/bin/bash
# Search for any discussion about h5py downgrade
rg -i "downgrade.*h5py|h5py.*downgrade" --type md --type txt 2>/dev/null | head -10Repository: pyiron/executorlib
Length of output: 44
Document the rationale for downgrading h5py in the CI integration environment.
This change downgrades h5py from 3.15.1 to 3.15.0 specifically in .ci_support/environment-integration.yml, while the binder environment remains on 3.15.1. The PR title indicates this is a test. However, note that 3.15.1 is a bugfix release that fixed a macOS wheel regression present in 3.15.0.
Clarify what the downgrade is testing—is this to verify backward compatibility, isolate a specific issue, or reproduce a failure? Add a comment in the file or update the PR description explaining the test objective so future maintainers understand the purpose of this version constraint.
🤖 Prompt for AI Agents
In .ci_support/environment-integration.yml around line 4 the h5py version was
changed to 3.15.0 without documenting why this downgrade (from 3.15.1 used in
binder) is being done; add a short comment directly above the h5py line
explaining the specific rationale for pinning 3.15.0 (e.g., reproducing a bug,
testing backward compatibility, isolating an issue), and/or update the PR
description to state the exact test objective and expected outcome so future
maintainers understand why CI differs from binder.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #880 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 38 38
Lines 1800 1800
=======================================
Hits 1679 1679
Misses 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.