-
Notifications
You must be signed in to change notification settings - Fork 3
Update integration test environment #871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates three dependency versions in the CI environment specification file: h5py to 3.15.1, atomistics to 0.3.4, and flux-core to 0.79.0. No dependencies are added or removed; only version numbers are modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #871 +/- ##
=======================================
Coverage 93.27% 93.27%
=======================================
Files 38 38
Lines 1800 1800
=======================================
Hits 1679 1679
Misses 121 121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.ci_support/environment-integration.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (17)
- GitHub Check: unittest_mpich (ubuntu-24.04-arm, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-24.04-arm, 3.13)
- GitHub Check: unittest_mpich (ubuntu-22.04-arm, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.11)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.11)
- GitHub Check: unittest_mpich (ubuntu-latest, 3.13)
- GitHub Check: unittest_openmpi (ubuntu-latest, 3.12)
- GitHub Check: unittest_flux_mpich
- GitHub Check: unittest_openmpi (ubuntu-22.04-arm, 3.13)
- GitHub Check: unittest_mpich (macos-latest, 3.13)
- GitHub Check: unittest_slurm_mpich
- GitHub Check: unittest_win
- GitHub Check: notebooks_integration
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-openmpi.yml)
- GitHub Check: unittest_flux_openmpi
- GitHub Check: benchmark (ubuntu-latest, 3.13, .ci_support/environment-mpich.yml)
- GitHub Check: notebooks
🔇 Additional comments (2)
.ci_support/environment-integration.yml (2)
4-4: h5py 3.15.1 is available on conda-forge. The patch version bump from 3.15.0 is a standard bugfix update and the version is available across multiple platforms (linux-64, linux-aarch64, linux-ppc64le, osx-64, osx-arm64, win-64). No action needed.
12-12: flux-core 0.79.0 is available on conda-forge — version jump is significant but acceptable for integration tests.Version 0.79.0 is available on conda-forge. The 15 minor version jump is substantial, and since flux-core is at major version zero with unstable interfaces, any breaking changes would be announced in the release notes. However, for CI integration tests, any compatibility issues will be caught by test failures, so the risk is limited.
| - openmpi | ||
| - papermill | ||
| - atomistics =0.3.0 | ||
| - atomistics =0.3.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify atomistics 0.3.4 exists on conda-forge
conda search -c conda-forge atomistics --info 2>/dev/null | grep -E "^atomistics\s+0\.3\.(0|1|2|3|4)" | head -20Repository: pyiron/executorlib
Length of output: 44
🏁 Script executed:
#!/bin/bash
# Broader search for atomistics on conda-forge
conda search -c conda-forge atomistics 2>/dev/null | head -30Repository: pyiron/executorlib
Length of output: 44
Atomistics version 0.3.4 does not exist on conda-forge.
Only v0.2.5 is available on conda-forge. Update the version to atomistics =0.2.5 or verify the correct version should be specified.
🤖 Prompt for AI Agents
In .ci_support/environment-integration.yml around line 10, the pinned package
version "atomistics =0.3.4" does not exist on conda-forge; change it to the
available version "atomistics =0.2.5" (or update to the correct valid version if
0.3.4 was intended but obtained from a different channel), and ensure the
dependency line matches conda-forge naming and spacing conventions so the CI
environment can resolve the package.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.