-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add poa_ prefix to returned names when return_components=True in transposition functions
#2627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kandersolar nice to see this moving! Will this be done also for Also, I guess I should address #1553 (which is being handled here #2527) on top of this right? Once you comment on my first question (and it is addressed, if I'm right) I can later review this PR, so that its merging is sped up. |
poa_ prefix to returned named when return_components=True in transposition functionspoa_ prefix to returned names when return_components=True in transposition functions
No, the idea here was to make only the breaking changes (changing returned dict key/dataframe column names), which only affect the functions that already have the
Better to keep them separate because smaller, focused PRs are easier to review, and because it means we can be sure to get the breaking changes into the next release (a .0 release) even if the enhancements aren't ready in time.
The names of actual variables in the code are not user-facing, so strictly speaking it doesn't matter if they match the docstring (or anything else). If we want to change them to have
Hopefully the above addresses this :) These two changes can be worked on independently. I do think this PR achieves the intended scope and is ready for review though. |
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
|
I thought the discussion in #2529 indicated that this change would happen in v0.14, since its breaking? |
|
The imminent release, which was once called v0.13.2, will be v0.14.0 instead. The whatsnew will be renamed in the release PR, and I need to clean up the milestones too. |
* adapt to changed keys from pvlib perez function pvlib/pvlib-python#2627 * whatsnew * retain compatibility with older pvlib * fix mistake
|
CI is green after I retriggered everything following making a new solarfactors release (v1.6.1) with compatibility for this change. |
return_components=Truetransposition model outputs #2529[ ] Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Note that
pvfactors_timeseries(actually solarfactors under the hood) uses the old names, so the pvfactors tests are going to fail until solarfactors is updated and a new version released.