Skip to content

(BOLT-109) Fix Windows long path support by replacing Dir[] with Find.find #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malikparvez merged 1 commit into from
Dec 11, 2025
Merged

(BOLT-109) Fix Windows long path support by replacing Dir[] with Find.find #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lib/puppet_forge/unpacker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
require 'pathname'
require 'find'
require 'puppet_forge/error'
require 'puppet_forge/tar'

Expand Down Expand Up @@ -55,8 +56,23 @@ def move_into(dir)
def root_dir
return @root_dir if @root_dir

# Grab the first directory containing a metadata.json file
metadata_file = Dir["#{@tmpdir}/**/metadata.json"].sort_by(&:length)[0]
# Use Find.find instead of Dir[] for Windows long path support
metadata_file = nil
shortest_length = Float::INFINITY

begin
Find.find(@tmpdir) do |path|
if File.basename(path) == 'metadata.json'
if path.length < shortest_length
metadata_file = path
shortest_length = path.length
end
end
end
rescue Errno::ENAMETOOLONG => e
# Even Find.find might fail, need to use Dir.each with manual recursion
raise "Cannot traverse directory due to long paths: #{e.message}"
end

if metadata_file
@root_dir = Pathname.new(metadata_file).dirname
Expand Down
Loading