Skip to content

Use defusedxml for sax.parse(). #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliotwutingfeng wants to merge 2 commits into from
Closed

Use defusedxml for sax.parse(). #1228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccf427b
use defusedxml for sax.parse().
elliotwutingfeng Dec 31, 2025
4883a7a
use latest defusedxml.
elliotwutingfeng Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pre_commit_hooks/check_xml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@
import xml.sax.handler
from collections.abc import Sequence

import defusedxml

defusedxml.defuse_stdlib()


def main(argv: Sequence[str] | None = None) -> int:
parser = argparse.ArgumentParser()
Expand All @@ -15,7 +19,7 @@ def main(argv: Sequence[str] | None = None) -> int:
for filename in args.filenames:
try:
with open(filename, 'rb') as xml_file:
xml.sax.parse(xml_file, handler)
defusedxml.sax.parse(xml_file, handler)
except xml.sax.SAXException as exc:
print(f'{filename}: Failed to xml parse ({exc})')
retval = 1
Expand Down
1 change: 1 addition & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ classifiers =
[options]
packages = find:
install_requires =
defusedxml>=0.8.0rc2
ruamel.yaml>=0.15
tomli>=1.1.0;python_version<"3.11"
python_requires = >=3.10
Expand Down