Fix review form checkbox styling #45
Merged
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thank you, that looks much better. |
JelteF
pushed a commit
that referenced
this pull request
Mar 1, 2025
This fixes an issue I reported on the pgsql-www mailing list [1]. The checkboxes that were present on the review form were not displayed correctly. This makes some small css tweaks to address that problem. A better fix would probably be to generate different HTML, but that would require changing the way forms are rendered by Django for these checkboxes. Which is not trivial to do. So for now this fix is fine. Before:  After:  [1]: https://www.postgresql.org/message-id/flat/CADXhmgQbed%2BJP3o5szv15sKsT5gkfZi4urOSLsYoC-oAGepK7g%40mail.gmail.com
JelteF
pushed a commit
that referenced
this pull request
Mar 17, 2025
This fixes an issue I reported on the pgsql-www mailing list [1]. The checkboxes that were present on the review form were not displayed correctly. This makes some small css tweaks to address that problem. A better fix would probably be to generate different HTML, but that would require changing the way forms are rendered by Django for these checkboxes. Which is not trivial to do. So for now this fix is fine. Before:  After:  [1]: https://www.postgresql.org/message-id/flat/CADXhmgQbed%2BJP3o5szv15sKsT5gkfZi4urOSLsYoC-oAGepK7g%40mail.gmail.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue I reported on the pgsql-www mailing list 1.
The checkboxes that were present on the review form were not displayed correctly. This makes some small css tweaks to address that problem. A better fix would probably be to generate different HTML, but that would require changing the way forms are rendered by Django for these checkboxes. Which is not trivial to do. So for now this fix is fine.
Before:
After:
