-
Notifications
You must be signed in to change notification settings - Fork 17
Add interactive example #47
base: master
Are you sure you want to change the base?
Conversation
6cb1237 to
8393130
Compare
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 8 unresolved discussions (waiting on @igchor)
a discussion (no related file):
pls add run of this example in CI
examples/interactive_example.py, line 32 at r1 (raw file):
# Usage: # insert element: 'basic_example.py --path path_to_db --insert key value'
basic_ -> interactive_
examples/interactive_example.py, line 34 at r1 (raw file):
# insert element: 'basic_example.py --path path_to_db --insert key value' # lookup element: 'basic_example.py --path path_to_db --lookup key' # print all elemnets: 'basic_example.py --path path_to_db --iterate'
elemnets misspell
examples/interactive_example.py, line 46 at r1 (raw file):
parser = argparse.ArgumentParser() parser.add_argument('--path')
you can add 'help' for the param (https://docs.python.org/3/howto/argparse.html#introducing-optional-arguments)
examples/interactive_example.py, line 57 at r1 (raw file):
print("Configuring engine") config = {} config["path"] = "/dev/shm/t1"
t1 ? maybe pmemkv instead...?
examples/interactive_example.py, line 68 at r1 (raw file):
elif args.insert: db.put(args.insert[0], args.insert[1]) else:
just to be sure elif args.iterate: ;)
utils/docker/images/Dockerfile.fedora-31, line 2 at r1 (raw file):
# # Copyright 2016-2020, Intel Corporation
-2021 (in all files)
utils/docker/images/install-pmdk.sh, line 43 at r1 (raw file):
# stable-1.10 PMDK_VERSION="1.10"
pls use commit's hash (this way it works if you don't have tags on your fork)
8393130 to
6666e77
Compare
igchor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 8 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)
examples/interactive_example.py, line 32 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
basic_->interactive_
Done.
examples/interactive_example.py, line 34 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
elemnetsmisspell
Done.
examples/interactive_example.py, line 46 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
you can add 'help' for the param (https://docs.python.org/3/howto/argparse.html#introducing-optional-arguments)
Done.
examples/interactive_example.py, line 57 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
t1? maybepmemkvinstead...?
Done.
examples/interactive_example.py, line 68 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
just to be sure
elif args.iterate:;)
Done.
utils/docker/images/Dockerfile.fedora-31, line 2 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
-2021 (in all files)
Done.
utils/docker/images/install-pmdk.sh, line 43 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
pls use commit's hash (this way it works if you don't have tags on your fork)
Done.
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)
examples/interactive_example.py, line 57 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
Done.
that's even better :D
|
examples/interactive_example.py, line 54 at r2 (raw file):
missing |
6666e77 to
d8c5eac
Compare
This change is