Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Conversation

@igchor
Copy link
Contributor

@igchor igchor commented Apr 20, 2021

This change is Reviewable

@igchor igchor force-pushed the interactive_example branch from 6cb1237 to 8393130 Compare April 20, 2021 12:18
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 8 unresolved discussions (waiting on @igchor)

a discussion (no related file):
pls add run of this example in CI



examples/interactive_example.py, line 32 at r1 (raw file):

# Usage:
# insert element: 'basic_example.py --path path_to_db --insert key value'

basic_ -> interactive_


examples/interactive_example.py, line 34 at r1 (raw file):

# insert element: 'basic_example.py --path path_to_db --insert key value'
# lookup element: 'basic_example.py --path path_to_db --lookup key'
# print all elemnets: 'basic_example.py --path path_to_db --iterate'

elemnets misspell


examples/interactive_example.py, line 46 at r1 (raw file):

parser = argparse.ArgumentParser()
parser.add_argument('--path')

you can add 'help' for the param (https://docs.python.org/3/howto/argparse.html#introducing-optional-arguments)


examples/interactive_example.py, line 57 at r1 (raw file):

print("Configuring engine")
config = {}
config["path"] = "/dev/shm/t1"

t1 ? maybe pmemkv instead...?


examples/interactive_example.py, line 68 at r1 (raw file):

elif args.insert:
    db.put(args.insert[0], args.insert[1])
else:

just to be sure elif args.iterate: ;)


utils/docker/images/Dockerfile.fedora-31, line 2 at r1 (raw file):

#
# Copyright 2016-2020, Intel Corporation

-2021 (in all files)


utils/docker/images/install-pmdk.sh, line 43 at r1 (raw file):

# stable-1.10
PMDK_VERSION="1.10"

pls use commit's hash (this way it works if you don't have tags on your fork)

@igchor igchor force-pushed the interactive_example branch from 8393130 to 6666e77 Compare April 20, 2021 14:00
Copy link
Contributor Author

@igchor igchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 8 unresolved discussions (waiting on @igchor and @lukaszstolarczuk)


examples/interactive_example.py, line 32 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

basic_ -> interactive_

Done.


examples/interactive_example.py, line 34 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

elemnets misspell

Done.


examples/interactive_example.py, line 46 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

you can add 'help' for the param (https://docs.python.org/3/howto/argparse.html#introducing-optional-arguments)

Done.


examples/interactive_example.py, line 57 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

t1 ? maybe pmemkv instead...?

Done.


examples/interactive_example.py, line 68 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

just to be sure elif args.iterate: ;)

Done.


utils/docker/images/Dockerfile.fedora-31, line 2 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

-2021 (in all files)

Done.


utils/docker/images/install-pmdk.sh, line 43 at r1 (raw file):

Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…

pls use commit's hash (this way it works if you don't have tags on your fork)

Done.

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)


examples/interactive_example.py, line 57 at r1 (raw file):

Previously, igchor (Igor Chorążewicz) wrote…

Done.

that's even better :D

@karczex
Copy link

karczex commented Apr 21, 2021


examples/interactive_example.py, line 54 at r2 (raw file):

    help='Insert element with specified key and value')
group.add_argument('--iterate', action='store_true',
    help='Print all elements)

missing '

@igchor igchor force-pushed the interactive_example branch from 6666e77 to d8c5eac Compare May 6, 2021 10:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants