Fix clangd for JIT files #20741
Fix clangd for JIT files #20741
Conversation
| #include "zend_vm_opcodes.h" | ||
|
|
||
| #include "jit/zend_jit.h" | ||
| #include "jit/ir/ir.h" |
There was a problem hiding this comment.
IR related dependencies should be encapsulated in zend_jit_ir.h.
I know, this is not completely true now, but I wouldn't spread dependency even more.
dstogov
left a comment
dstogov
left a comment
There was a problem hiding this comment.
I didn't understand the reason for this permutation.
This doesn't make sources better at all, but would complicate merging between major branches.
I would understand making a better decomposition of JIT to separately compiled C files with minimized cross-dependencies. This is a bit bigger task, but it would beneficial for humans and not only for clangd.
|
My assumption was that the C files are included directly for better cross-file optimizations. I'm happy to try to split them comletely, though that won't exactly result in a smaller change or help with merge conflicts. It will add a huge header file for helpers with a silent conflict (no merge conflict, but if the signature of a helper changes, it will need to be updated in the header file in the master branch). Clangd is pretty essential for me to work in a codebase, especially one I don't know by heart. I don't care if it's this approach or if we can find something else, but it would be great to fix somehow. |
2 participants
No description provided.