WIP: Add Reasons to Block and Test Results #2607
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a reason property onto Block and Test results. Currently if you Skip a block using `-Skip` you cannot provide a reason for your skip. While if you use `Set-ItResult` to skip a test you're able to provide a reason for the result you're setting. Unfortunately with a Skip result, that reason is not bubbled up to the test results files.
This add some tests for what was run manually for testing this out. It is expected that this commit will not be included when the PR is merged, but it is valuable for getting to the point of being able to merge.
Contributor
Author
|
oooh... I had marked this as ready for review as I thought I was ready, but I see from the checks that the answer to my unknown about where to put tests is probably around where there are failing tests because reasons have been added... I guess I'll convert it back to draft until I've had an opportunity to look at that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add Reasons to block and test results. Allowing for providing a reason when skipping a block with
-Skip, or seeing the reported reason when usingSet-ItResult.Fixes #2049
Testing steps
Below are the steps that I took to test this change:
.\build.ps1 -Clean.\2049-tests\mytests.ps1A few things I'm not sure on:
PR Checklist
Create Pull Requestto mark it as a draft. PR can be markedReady for reviewwhen it's ready.