[FEATURE] updates nearby-series to support logarithmic scaled data #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
This change adds a scaling to the log-base data to convert it to a linear space for nearby series finding. If this is not present and you use a log-based chart, you end up having millions of data points within just a few pixels. --------- Signed-off-by: Simon Olander <simon.olander@sap.com>
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
55450e1 to
2233570
Compare
5 tasks
Contributor
|
@olandr can you check the lint errors? |
Author
|
Obviously using GH mobile does not auto add the DCO. So have to redo that commit after the holidays with proper DCO and lint fix. |
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
c575cfd to
424b00a
Compare
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
424b00a to
b994aeb
Compare
Author
Done! @jgbernalp |
jgbernalp
reviewed
Jan 6, 2026
Resolved linting by removing redundant mathjs dep (replaced with ** operator) Signed-off-by: Simon Olander <simon.olander@sap.com>
olandr
force-pushed
the
feat/logarithmic-support-3434
branch
from
b994aeb to
bcf1287
Compare
jgbernalp
approved these changes
Jan 6, 2026
Author
|
Is it just to merge it or should something else happen first? The contribution.md mentions squashing, but seems to me that this is not an option here. |
Member
|
thank you for the changes @olandr. @jgbernalp I am planning a new release for perses/perses. I believe this change should be part of it also. So I guess I should release the shared package as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a precondition for supporting perses/perses#3434. If a user has selected a log-base for their render, this will perform a base-change to convert the log-base vector space to a linear space for the logic handling nearby series finding.
Example
For instance If this is not present and you use a log-based chart, you end up with a "nearby-search interval" of just a few pixels. That is, if you have multiple series in the realm of ~1e4, using a log scale we would have y-values of ~4. The search interval would then be <4. But as the chart coordinates still are very large ~1e4 it would be impossible to get precise enough to hover/select a particular series.
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
There are no UI changes.