Skip to content

Conversation

@DavidHurta
Copy link
Contributor

No description provided.

@DavidHurta
Copy link
Contributor Author

/hold

Do Not Merge

@DavidHurta DavidHurta changed the title TEST: pkg/payload/render: Add OKD feature set logic Do Not Merge: pkg/payload/render: Add OKD feature set logic Jan 20, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A single file modification adds OKD to the conditional logic that skips certain manifest files during bootstrap rendering in the payload module. The expanded skip condition now includes OKD alongside CustomNoUpgrade, TechPreviewNoUpgrade, and DevPreviewNoUpgrade. The explanatory comment is updated accordingly.

Changes

Cohort / File(s) Summary
Bootstrap manifest skip logic
pkg/payload/render.go
Added OKD to the conditional that skips manifest files during bootstrap rendering; updated comment to reflect expanded skip conditions

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2026
@DavidHurta DavidHurta marked this pull request as draft January 20, 2026 14:07
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2026
@DavidHurta
Copy link
Contributor Author

/test all

@hongkailiu
Copy link
Member

/test e2e-agnostic-operator

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 21, 2026

@DavidHurta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance dd3b833 link true /test e2e-hypershift-conformance
ci/prow/e2e-hypershift dd3b833 link true /test e2e-hypershift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@hongkailiu
Copy link
Member

Let us see if openshift/hypershift#7557 fixes the HyperShift part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants