-
Notifications
You must be signed in to change notification settings - Fork 73
OCPBUGS-69803: change service.alpha to service.beta in metrics-service.yaml #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-69803, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira refresh |
|
@abhay-nutanix: This pull request references Jira Issue OCPBUGS-69803, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@gpei: This pull request references Jira Issue OCPBUGS-69803, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
@abhay-nutanix: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@abhay-nutanix Hi, I'm trying to pre-merge testing this bug by |
|
this is just changing the service to beta from alpha |
The service.alpha.openshift.io/serving-cert-secret-name annotation is deprecated. The service-ca-operator now only watches for service.beta.openshift.io/serving-cert-secret-name.
Since the Service uses the old alpha annotation, the service-ca-operator never creates the TLS secret, causing the kube-rbac-proxy container to crash because /etc/tls/private/tls.crt doesn't exist.