Skip to content

Align chat named tool choice param with docs #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
majiayu000 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Align chat named tool choice param with docs #2800

majiayu000 wants to merge 2 commits into from
+14 −9

Conversation

@majiayu000
Copy link

@majiayu000 majiayu000 commented Dec 21, 2025 •
edited
Loading

Summary

  • update chat named tool choice param to use top-level name field
  • add regression test to ensure name is the documented key
  • adjust video API tests to use supported model values

Testing

  • PYTHONPATH=src pytest tests/test_chat_completion_tool_choice_param.py -o addopts= -o filterwarnings= -p no:benchmark
  • env -u http_proxy -u https_proxy -u HTTP_PROXY -u HTTPS_PROXY -u ALL_PROXY -u all_proxy PYTHONPATH=src pytest -o addopts= -o filterwarnings= -p no:benchmark

@majiayu000 majiayu000 requested a review from a team as a code owner December 21, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@majiayu000