Skip to content

Conversation

@parmesant
Copy link

@parmesant parmesant commented Dec 11, 2025

Fixes #2487
Design discussion issue (if applicable) #

Changes

This PR adds to the changes made by @lalitb in his PR #2491

For metric type Summary, quantileValues.quantile gets treated as u64 and not f64 when its value is 1

Also, flags comes optionally in the payload hence added default to it (and some other fields)

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@parmesant parmesant requested a review from a team as a code owner December 11, 2025 07:20
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 11, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.5%. Comparing base (07bb613) to head (45fb828).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3284   +/-   ##
=====================================
  Coverage   80.5%   80.5%           
=====================================
  Files        129     129           
  Lines      23286   23286           
=====================================
  Hits       18748   18748           
  Misses      4538    4538           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@parmesant parmesant changed the title Fix metrics u64 serialization fix: metrics u64 deserialization Dec 11, 2025
@parmesant parmesant changed the title fix: metrics u64 deserialization fix: serialization/deserialization for u64, f64, and "NaN" float fields in Metrics Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialization Fails for u64 Fields Due to Incoming String Values in OpenTelemetry Metrics

2 participants