Fix duplicate HELP/TYPE declarations in Prometheus exporter #4869
+106
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes open-telemetry#4868 The Prometheus exporter was generating duplicate HELP and TYPE declarations for metrics with varying label sets, violating the Prometheus format specification and causing rejection by Prometheus Pushgateway with the error: "second HELP line for metric name." Changes: - Modified metric family ID to exclude label keys, using only metric name, description, and unit - Implemented two-pass processing: first pass collects all unique label keys across data points, second pass builds label values with empty strings for missing labels - Ensured single metric family per metric type with consolidated label keys - Updated test expectations to verify single HELP/TYPE declaration with proper empty string handling for missing labels This aligns with the Go implementation approach and ensures compatibility with Prometheus Pushgateway and other strict validators.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Prometheus exporter was generating duplicate HELP and TYPE declarations for metrics with varying label sets, violating the Prometheus format specification and causing rejection by Prometheus Pushgateway with the error: "second HELP line for metric name."
Changes:
This aligns with the Go implementation approach and ensures compatibility with Prometheus Pushgateway and other strict validators.
Fixes #4868
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
It's important to set OTEL_SEMCONV_STABILITY_OPT_IN=http and make both successful and failed requests, then optional
error_typelabel would previously cause duplicate metrics and now be set to empty string if not present.Does This PR Require a Contrib Repo Change?
Checklist: