feat: format known addresses #616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oasisprotocol-cli canceled.
|
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
0068b35 to
95ace6e
Compare
Member
|
This would be nice addition. @uniyalabhishek can you rebase? @matevz can you review please? |
Contributor
Author
@ptrus sorry, this PR is not fully ready for review now (also oasisprotocol/oasis-sdk#2335). there have been higher-priority tasks and missed completing this. will prioritise it this week. |
uniyalabhishek
force-pushed
the
uniyalabhishek/feature/format-known-addresses-131
branch
from
95ace6e to
ee0dbb3
Compare
Member
|
FYI I'll be refactoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #131 & #523