fix: process all data on_output, even when not terminated with newline #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current condition prematurely quits processing of data in on_output in some edge-cases. In these cases `job:result()` will have all data, but not everyting was sent through the `on_output` pipes. Closes nvim-lua#634
Contributor
Author
|
@Conni2461 could you please trigger the CI for this? I re-enabled two related pending tests and they looked good locally. Thanks a lot for your support! |
Collaborator
|
thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current condition prematurely quits processing of data in on_output
in some edge-cases.
In these cases
job:result()will have all data, but not everyting wassent through the
on_outputpipes.Closes #634
Thanks for your support, please let me know your thoughts!