Changes fix and change integration of the REST server, including a sh… #94
+1,551
−3,822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utdown test. Cleanup tests that had mocha describe functions inner to it functions, making output hard to understand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4.1, there was a merge issue that made the REST server fail when started. The merge error was removed, but really the integration of the REST server as a singleton was changed, now relying on the nature of caching files with the request directive. The goal is to allow different parts of the driver or extensions to the code, like the multiplexer, can register functions for the REST interface to provide. Later driver releases will continue to add commands provided the REST server is accepted by 3DMessaging. For the time being the REST server remains a preview feature just for their trial usage.
In order to avoid basics of REST server problems, a test was added to make a REST call to shutdown the server. This will at least show the REST server mechanics are operational. The REST server can be triggered by an environment variable NUODB_NODEJS_REST=true, which has been added as the default in .env file that is loaded when commands are sent to docker for execution.
The connection tests were written in a way that had the mocha describe function that were used inside "it" functions. This is not expected, and results in strangely ordered test output. The tests were rewritten to change their scoping.