Skip to content

Update simpleFlake #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xiaoyuechen wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update simpleFlake #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fd18ca
Update simpleFlake
xiaoyuechen Nov 17, 2023
91aab31
Add defaultPackage to simpleFlake
xiaoyuechen Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions simpleFlake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,17 +64,22 @@ let
} else { }
)
//
(
if packages ? default then {
packages.default = packages.default;
} else { }
)
//
(
if packages ? checks then {
checks = packages.checks;
} else { }
)
//
(
if shell != null then {
devShell = shell_ { inherit pkgs; };
} else if packages ? devShell then {
devShell = packages.devShell;
Comment on lines -76 to -77
Copy link
Member

@zimbatm zimbatm Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still needed

Copy link
Author

@xiaoyuechen xiaoyuechen Nov 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it also for back-compat? From nix3-develop manual:

Flake output attributes
If no flake output attribute is given, nix develop tries the following
flake output attributes:

   •  devShells.<system>.default

   •  packages.<system>.default

if shell != null then rec {
devShells.${name} = shell_ { inherit pkgs; };
devShells.default = devShells.${name};
} else { }
)
);
Expand Down