-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: mobile dialog close icon #8446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website Please review the changes when you have a chance. Thank you! 🙏 |
|
@nodejs/nodejs-website can we fast track this as a hotfix? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8446 +/- ##
==========================================
- Coverage 73.64% 73.59% -0.05%
==========================================
Files 108 108
Lines 9193 9193
Branches 312 313 +1
==========================================
- Hits 6770 6766 -4
- Misses 2421 2425 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a critical usability issue where the mobile search dialog couldn't be closed once opened, and addresses Safari's auto-zoom behavior on small input fields.
- Added a close button to the search modal for mobile users
- Increased input font size to 16px on mobile to prevent Safari from zooming in on focus
- Applied consistent dark mode styling to the new close button
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/ui-components/src/Common/Search/Modal/index.tsx | Added Modal.Close component with custom styling class |
| packages/ui-components/src/Common/Search/Modal/index.module.css | Added styling for the close button with absolute positioning and dark mode support |
| packages/ui-components/src/Common/Search/Input/index.module.css | Changed input font size from text-sm to text-base on mobile, text-sm on md+ breakpoints to prevent Safari auto-zoom |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Whoops! |
Description
I didn’t get a chance to review #8443 in time, and when I checked it, I couldn’t exit the dialog once it was opened. With this PR, I added a simple close icon. Also, Safari tends to zoom in on inputs with font sizes below 16px, so I set the input font size to 16px for mobile resolutions
Validation
Before
After