-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
doc: clarify status of feature request issues #61505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aduh95
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
aduh95:feature-requests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−8
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,13 +1,15 @@ | ||||||||||
| # Feature request management | ||||||||||
|
|
||||||||||
| Feature requests are a valuable source of input to the project. | ||||||||||
| They help our maintainers understand what additions will be of | ||||||||||
| value to users of the Node.js runtime. | ||||||||||
|
|
||||||||||
| At the same time, the project is volunteer run and does not | ||||||||||
| have the ability to direct resources toward specific work. The | ||||||||||
| features which are implemented are those for which volunteers | ||||||||||
| are individually motivated to work on. The best way to ensure | ||||||||||
| Feature requests are not a valuable source of input for the project. | ||||||||||
| It is usually more productive to first send the Pull Request implementing the | ||||||||||
| feature, even imperfectly, and let the discussion happen during code review. | ||||||||||
|
Comment on lines
+4
to
+5
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What if the implemented feature is what you really don't want to, which will end up with great-pains-but-all-in-vain? |
||||||||||
| That being said, the project still welcomes feature request issues, either for | ||||||||||
| features you cannot and/or won't implement yourself, or if you need more input | ||||||||||
| from the community before starting the work. | ||||||||||
|
|
||||||||||
| The project is volunteer run and does not have the ability to direct resources | ||||||||||
| toward specific work. The features which are implemented are those for which | ||||||||||
| volunteers are individually motivated to work on. The best way to ensure | ||||||||||
| a feature gets implemented is to create a PR to add it. | ||||||||||
| The project strives to support people who do that. | ||||||||||
|
|
||||||||||
|
|
||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tones down the message a little, whilst still discouraging feature requests as primary sources of input.