Skip to content

Conversation

@btea
Copy link
Contributor

@btea btea commented Dec 25, 2025

Description

image

Different types are already separated by |, so there's no need to add extra margins through styles.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run node --run test and all tests passed.
  • I have check code formatting with node --run format & node --run lint.
  • I've covered new added functionality with unit tests if necessary.

Copilot AI review requested due to automatic review settings December 25, 2025 05:08
@btea btea requested a review from a team as a code owner December 25, 2025 05:08
@vercel
Copy link

vercel bot commented Dec 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
api-docs-tooling Ready Ready Preview Dec 25, 2025 5:09am

@codecov
Copy link

codecov bot commented Dec 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.82%. Comparing base (902999d) to head (36d9373).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   79.82%   79.82%           
=======================================
  Files         121      121           
  Lines       12017    12017           
  Branches      840      840           
=======================================
  Hits         9593     9593           
  Misses       2421     2421           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses excess margin between type links in API documentation tables. The change removes right margin from consecutive anchor elements that represent different types, as these types are already visually separated by the | character.

Key Changes:

  • Added CSS rule to remove margin-right from consecutive anchor elements (a + a) within table cells inside overflow containers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

overflow-x: auto;
width: 100%;
table td a + a {
margin-right: 0;
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using margin-right: 0 on the a + a selector removes right margin from all anchors except the first. If the intent is to remove spacing between consecutive type links (as mentioned in the PR description about types separated by |), using margin-left: 0 would be more semantically correct, as it would remove the left margin from subsequent anchors, eliminating the space before them. Verify which margin direction is being applied by the base styles to ensure this override targets the correct property.

Suggested change
margin-right: 0;
margin-left: 0;

Copilot uses AI. Check for mistakes.
Comment on lines +23 to +25
table td a + a {
margin-right: 0;
}
Copy link

Copilot AI Dec 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table-related style is nested inside the .overflow-container block, but there's already a dedicated table block at lines 28-33 where other table anchor styles are defined. For better maintainability and consistency, consider moving this rule to the existing table block. The selector could be adjusted to td a + a to achieve the same specificity while keeping table styles organized together.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant