-
Notifications
You must be signed in to change notification settings - Fork 21
fix: remove excess margin between types #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 79.82% 79.82%
=======================================
Files 121 121
Lines 12017 12017
Branches 840 840
=======================================
Hits 9593 9593
Misses 2421 2421
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses excess margin between type links in API documentation tables. The change removes right margin from consecutive anchor elements that represent different types, as these types are already visually separated by the | character.
Key Changes:
- Added CSS rule to remove
margin-rightfrom consecutive anchor elements (a + a) within table cells inside overflow containers
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| overflow-x: auto; | ||
| width: 100%; | ||
| table td a + a { | ||
| margin-right: 0; |
Copilot
AI
Dec 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using margin-right: 0 on the a + a selector removes right margin from all anchors except the first. If the intent is to remove spacing between consecutive type links (as mentioned in the PR description about types separated by |), using margin-left: 0 would be more semantically correct, as it would remove the left margin from subsequent anchors, eliminating the space before them. Verify which margin direction is being applied by the base styles to ensure this override targets the correct property.
| margin-right: 0; | |
| margin-left: 0; |
| table td a + a { | ||
| margin-right: 0; | ||
| } |
Copilot
AI
Dec 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This table-related style is nested inside the .overflow-container block, but there's already a dedicated table block at lines 28-33 where other table anchor styles are defined. For better maintainability and consistency, consider moving this rule to the existing table block. The selector could be adjusted to td a + a to achieve the same specificity while keeping table styles organized together.
Description
Different types are already separated by
|, so there's no need to add extra margins through styles.Validation
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.