Skip to content

Conversation

@bjee19
Copy link
Contributor

@bjee19 bjee19 commented Nov 27, 2025

Proposed changes

Problem: A design is needed for the RateLimitPolicy.

Solution: Create an implementable RateLimitPolicy enhancement proposal.

Closes #4059

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.28%. Comparing base (421674e) to head (654d2e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4346      +/-   ##
==========================================
- Coverage   86.33%   86.28%   -0.05%     
==========================================
  Files         132      132              
  Lines       14859    14859              
  Branches       35       35              
==========================================
- Hits        12828    12821       -7     
- Misses       1813     1817       +4     
- Partials      218      221       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale Pull requests/issues with no activity label Dec 16, 2025
@bjee19 bjee19 removed the stale Pull requests/issues with no activity label Dec 16, 2025
@bjee19
Copy link
Contributor Author

bjee19 commented Dec 17, 2025

Update: going to be scaling back this design to match more closely whats described in the story. Global rate limiting and Conditional rate limiting will be future work.

@bjee19 bjee19 marked this pull request as ready for review December 17, 2025 23:29
@bjee19 bjee19 requested review from a team as code owners December 17, 2025 23:29
Copy link
Collaborator

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@shaun-nx shaun-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Ben! 🚀

I left one other question here. Feel free to resolve that one after you post your reply 😃

@bjee19 bjee19 force-pushed the docs/rate-limit-impl branch from 5f65de4 to 654d2e8 Compare December 19, 2025 17:45
@bjee19
Copy link
Contributor Author

bjee19 commented Dec 19, 2025

Going to resolve the answered conversations and merge, we can revisit the proposal at any time

@bjee19 bjee19 merged commit f2ebf93 into main Dec 19, 2025
60 checks passed
@bjee19 bjee19 deleted the docs/rate-limit-impl branch December 19, 2025 19:22
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Design Rate Limiting

7 participants