-
Notifications
You must be signed in to change notification settings - Fork 154
Implementable RateLimitPolicy proposal #4346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4346 +/- ##
==========================================
- Coverage 86.33% 86.28% -0.05%
==========================================
Files 132 132
Lines 14859 14859
Branches 35 35
==========================================
- Hits 12828 12821 -7
- Misses 1813 1817 +4
- Partials 218 221 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
Update: going to be scaling back this design to match more closely whats described in the story. Global rate limiting and Conditional rate limiting will be future work. |
sjberman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
shaun-nx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job Ben! 🚀
I left one other question here. Feel free to resolve that one after you post your reply 😃
5f65de4 to
654d2e8
Compare
|
Going to resolve the answered conversations and merge, we can revisit the proposal at any time |
Proposed changes
Problem: A design is needed for the RateLimitPolicy.
Solution: Create an implementable RateLimitPolicy enhancement proposal.
Closes #4059
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.