-
Notifications
You must be signed in to change notification settings - Fork 112
fix(viewer): mount text vue instance explicitely #8153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d2ed97e to
dcf6af5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
c6d2f54 to
c721af4
Compare
a01b5e7 to
a0d1f22
Compare
|
I'm unsure if we have a test for #5531 these days but should double check this case |
We do have this: text/cypress/e2e/attachments.spec.js Lines 301 to 330 in 302dcc7
( I know because it was broken initially.) The editor for the text file in a text file renders fine. |
The component configured in the viewer handler is instantiated from the vue module inside the viewer. We want to use our own vue module so create an instance with an import of our own vue and mount it. This fixes warnings in development like $attrs is readonly. Also makes the vue2 dev tools work. Signed-off-by: Max <max@nextcloud.com>
It is not needed anymore now that the editor is always imported from text. Previously the ViewerComponent was used directly from the viewer which resulted in the editor and thus yjs being imported in two different ways. Signed-off-by: Max <max@nextcloud.com>
a0d1f22 to
cc8e8fd
Compare


The component configured in the viewer handler
is instantiated from the vue module inside the viewer.
We want to use our own vue module so create an instance explicitely and mount it.
This fixes warnings in development like $attrs is readonly.
It also makes the vue dev tools work!