Fix JSON serialization error in get_installed_apps() #20994
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #20993
Summary
This PR adds a defensive check in
get_installed_apps()to skip VERSION attributes that are neither tuples nor strings, preventing JSON serialization errors in the/api/status/endpoint.The Problem:
Some packages (like
django-health-checkusingsetuptools-scm) define theirVERSIONattribute as a type placeholder at runtime rather than an actual version value:When
get_installed_apps()encounters this, it includes<class 'object'>in the dictionary, which fails JSON serialization.The Fix:
Add an
elifbranch to skip non-serializable version types:This is a minimal, defensive change that:
Testing:
Verified fix resolves the issue with
django-health-check3.20.0 installed.