Skip to content

Conversation

@ash-wright123
Copy link
Collaborator

Issue

https://mxcom.atlassian.net/browse/CT-1323

Changes

Added focus to back button instead of checking button for accessibility

Testing Instructions

  • On iPhone go to connect and turn voice over on
  • Go to manual accounts the focus should now be on the back button
  • No harm test

@ash-wright123 ash-wright123 added the Needs Review This item needs review label Apr 7, 2025
@mwclemy
Copy link
Collaborator

mwclemy commented Apr 8, 2025

Is BECU fine with this solution? It looks good to me, but I just wanted to confirm that it resolves their issue.

@ash-wright123
Copy link
Collaborator Author

According to the ticket they think the order should go from the back button down. Unless I missed something?

mwclemy
mwclemy previously approved these changes Apr 8, 2025
Copy link
Collaborator

@mwclemy mwclemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mwclemy mwclemy removed the Needs Review This item needs review label Apr 8, 2025
@ash-wright123 ash-wright123 merged commit 30ff6e0 into master Apr 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants