Skip to content

Jameson/CT-1711 | Add more AED mapping #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Jameson13B merged 8 commits into from
Sep 25, 2025
Merged

Jameson/CT-1711 | Add more AED mapping #217

Jameson13B merged 8 commits into from
Sep 25, 2025

Conversation

@Jameson13B
Copy link
Collaborator

@Jameson13B Jameson13B commented Sep 19, 2025 •
edited
Loading

https://mxcom.atlassian.net/browse/CT-1711

Changes

  • Refactor ActionableError component and add useActionableErrorMap for error handling.
  • Enhance error codes in consts

Testing instructions

  • Run CW and MX unit tests.
  • Run MX E2E tests.

@Jameson13B Jameson13B self-assigned this Sep 19, 2025
Jameson13B
Jameson13B commented Sep 19, 2025
View reviewed changes
@Jameson13B Jameson13B added the Needs Review This item needs review label Sep 19, 2025
@codingLogan
Copy link
Collaborator

codingLogan commented Sep 25, 2025 •
edited
Loading

I'm reviewing this now

All Unit tests pass

All e2e tests pass

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  group-1/additionalProduct.cy.js          06:46        9        9        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-1/additionalProductNotSupport      00:15        1        1        -        -        - │
  │    ed.cy.js                                                                                    │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-1/externalLinkPopUp.cy.js          00:38        3        3        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-2/connectHappyPath.cy.js           03:43       11       11        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-2/connections.cy.js                03:20        6        6        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-2/iavConnectAccountNonDda.cy.      01:23        6        6        -        -        - │
  │    js                                                                                          │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-2/newUserWithNoAccounts.cy.js      00:10        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-2/postMessages.cy.js               00:06        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/comboJob.cy.js                   02:27        8        8        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/connectConfigTests.cy.js         01:26        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/globalNavTests.cy.js             02:52        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/jobError.cy.js                   00:18        1        1        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/lightDisclosure.cy.js            05:31       40       40        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-3/memberUseCases.cy.js             01:22        3        3        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-4/Search.cy.js                     01:00        8        8        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-4/connectSadPath.cy.js             01:55        7        7        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-4/mfaChallenges.cy.js              01:45        2        2        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  group-4/singleAccountSelect.cy.js        01:26        3        3        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        36:33      122      122        -        -        -

@codingLogan codingLogan removed the Needs Review This item needs review label Sep 25, 2025
@Jameson13B Jameson13B merged commit 48cc6c8 into master Sep 25, 2025
5 checks passed
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

🎉 This PR is included in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codingLogan codingLogan codingLogan approved these changes

@ash-wright123 ash-wright123 Awaiting requested review from ash-wright123 ash-wright123 is a code owner

@mwclemy mwclemy Awaiting requested review from mwclemy mwclemy is a code owner

@wesrisenmay-mx wesrisenmay-mx Awaiting requested review from wesrisenmay-mx wesrisenmay-mx is a code owner

Assignees

@Jameson13B Jameson13B

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jameson13B @codingLogan