Added compassflip and compassoffset & fixed declination calculations when using negative values #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed declination calculations when using negative degrees
symplerllc
approved these changes
Apr 5, 2025
There was a problem hiding this comment.
Thanks Sakisdog - the changes you made solved my problems: (1) reverse directions (needed flip) and after multiple successful calibrations (tested, plotted, and confirmed), I still had a 90-degree offset. The changes are working as intended. If I had write access we could get this pr done. These changes really do need to be in the codebase.
Author
|
Thank you! I am glad i could help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added compassflip and compassoffset properties. Very usefull when used with a GPS+compass module. Most of the time this modules have the compass point at 90 degrees offset in comparison with the GPS front.
Also fixed the calculation of compass declination when used with negative degrees.