Skip to content

Small: Simplifying read_file/write_file for better encapsulation/cohesion #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ScoGroMSFT wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small: Simplifying read_file/write_file for better encapsulation/cohesion #155

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions scripts/helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import os
import pandas as pd
import pathlib


def split_data(data_path, time_column_name, split_date):
Expand All @@ -16,28 +17,29 @@ def split_data(data_path, time_column_name, split_date):
if path not in (train_data_path, inference_data_path)]

for file in files_list:
file_name = os.path.basename(file)
file_extension = os.path.splitext(file_name)[1].lower()
df = read_file(file, file_extension)
df = read_file(file)

before_split_date = df[time_column_name] < split_date
train_df, inference_df = df[before_split_date], df[~before_split_date]

write_file(train_df, os.path.join(train_data_path, file_name), file_extension)
write_file(inference_df, os.path.join(inference_data_path, file_name), file_extension)
file_name = os.path.basename(file)
write_file(train_df, os.path.join(train_data_path, file_name))
write_file(inference_df, os.path.join(inference_data_path, file_name))

return train_data_path, inference_data_path


def read_file(path, extension):
if extension == ".parquet":
def read_file(path):
extension = pathlib.Path(path.lower()).suffix
if extension == "parquet":
return pd.read_parquet(path)
else:
return pd.read_csv(path)


def write_file(data, path, extension):
if extension == ".parquet":
def write_file(data, path):
extension = pathlib.Path(path.lower()).suffix
if extension == "parquet":
data.to_parquet(path)
else:
data.to_csv(path, index=None, header=True)