-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Update VCPKG to 25.08.27 #26839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update VCPKG to 25.08.27 #26839
Conversation
This automated commit updates the vcpkg dependency to version 2025.08.27 and its corresponding commit hash 120deac30621.
…osoft/onnxruntime into dev/update-vcpkg-2025.08.27
…-try-revive-vcpkg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can commit the suggested changes from lintrunner.
tianleiwu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Below are summary from AI
VCPKG Update Review Summary
Executive Summary
The PR successfully updates the VCPKG baseline and Abseil dependency to version 20250814.0. A significant improvement is the introduction of a dynamic dependency resolution script for Abseil. There are also substantial refactoring changes in the WebGPU provider build logic which appear to be bundled with this update.
Key Changes Verified
1. VCPKG & Abseil Update
- VCPKG Baseline: Updated to
120deac3062162151622ca4860575a33844ba10bin cmake/vcpkg-configuration.json. - Abseil Port: cmake/vcpkg-ports/abseil/vcpkg.json and
portfile.cmakecorrectly updated to version20250814.0. - Dependencies: cmake/deps.txt reflects the correct URL and hash for the new Abseil version.
2. Dependency Management
- New Tool: tools/python/resolve_absl_deps_dynamic.py has been added.
- Review: This is a robust script that automatically resolves and topologically sorts Abseil dependencies by parsing CMake lists. This is a great addition for maintainability, replacing the manual list management.
- CMake Integration: cmake/external/abseil-cpp.cmake has been updated to use the new list of components, consistent with the script's output.
Conclusion
The core VCPKG and Abseil updates look correct and well-implemented. The improved dependency management is a strong positive.
Description
Motivation and Context