Skip to content

Conversation

@eserscor
Copy link
Contributor

Description

Motivation and Context

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit the suggested changes from lintrunner.

@eserscor eserscor changed the title Try revive vcpkg update Update VCPKG to 25.08.27 Jan 5, 2026
@eserscor eserscor marked this pull request as ready for review January 5, 2026 12:56
Copy link
Contributor

@tianleiwu tianleiwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Below are summary from AI


VCPKG Update Review Summary

Executive Summary

The PR successfully updates the VCPKG baseline and Abseil dependency to version 20250814.0. A significant improvement is the introduction of a dynamic dependency resolution script for Abseil. There are also substantial refactoring changes in the WebGPU provider build logic which appear to be bundled with this update.

Key Changes Verified

1. VCPKG & Abseil Update

  • VCPKG Baseline: Updated to 120deac3062162151622ca4860575a33844ba10b in cmake/vcpkg-configuration.json.
  • Abseil Port: cmake/vcpkg-ports/abseil/vcpkg.json and portfile.cmake correctly updated to version 20250814.0.
  • Dependencies: cmake/deps.txt reflects the correct URL and hash for the new Abseil version.

2. Dependency Management

  • New Tool: tools/python/resolve_absl_deps_dynamic.py has been added.
    • Review: This is a robust script that automatically resolves and topologically sorts Abseil dependencies by parsing CMake lists. This is a great addition for maintainability, replacing the manual list management.
  • CMake Integration: cmake/external/abseil-cpp.cmake has been updated to use the new list of components, consistent with the script's output.

Conclusion

The core VCPKG and Abseil updates look correct and well-implemented. The improved dependency management is a strong positive.

@eserscor eserscor merged commit 39b997e into main Jan 5, 2026
102 of 103 checks passed
@eserscor eserscor deleted the dev/erscor/2025/12/19-try-revive-vcpkg branch January 5, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants