Remove ownerDocument in ProcessingInstruction #2336
Merged
+0
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Collaborator
|
This is from Node, one of ancestors. I recommend to check git blame history to see why this is added. |
Contributor
Author
|
Sorry for the late reply I was working out But It is still not clear to me, no browser has it |
Collaborator
|
ProcessingInstruction inherits CharacterData which then inherits Node. Node has ownerDocument. |
Collaborator
|
Hmm. But CharacterData has the same overriding type, so ProcessingInstruction shouldn't need another one. This should be good but the PR description should be different. |
Contributor
Author
|
I have updated the pr |
Collaborator
|
LGTM |
Contributor
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the same as in CharacterData