-
Notifications
You must be signed in to change notification settings - Fork 208
Add azure_monitor to metrics exporter for AKS #4575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xiang17
wants to merge
16
commits into
microsoft:main
Choose a base branch
from
xiang17:xiang17/aksMetrics-azure_monitor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+411
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanbisutti
reviewed
Jan 6, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
…ALYTICS_ENABLED env var on AKS
jeanbisutti
reviewed
Jan 22, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
Jan 22, 2026
trask
reviewed
Jan 22, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 22, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 22, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 23, 2026
.../src/main/java/com/microsoft/applicationinsights/agent/internal/init/AiConfigCustomizer.java
Outdated
Show resolved
Hide resolved
Comment on lines
+374
to
+375
| // if azure monitor is already present and otlp is not, add otlp | ||
| metricsExporter += ",otlp"; |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't understand why adding otlp here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # .
If
APPLICATIONINSIGHTS_METRICS_TO_LOGANALYTICS_ENABLEDis set totrue, send OTel metrics to Breeze even ifOTEL_METRICS_EXPORTERdoesn't haveazure_monitor.For significant contributions please make sure you have completed the following items: