Skip to content

Prevent index out of bounds in GetStringValue #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
majst01 merged 2 commits into from
Jan 16, 2026
Merged

Prevent index out of bounds in GetStringValue #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e995aa
Prevent index out of bounds in GetStringValue
majst01 Jan 16, 2026
b862436
Merge branch 'main' of https://github.com/metal-stack/api into preven…
majst01 Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go/enum/parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ func GetStringValue[E protoreflect.Enum](e E) (*string, error) {
return nil, fmt.Errorf("given enum is a nil pointer")
}
}
if e.Descriptor().Values().Len() <= int(e.Number()) {
return nil, fmt.Errorf("given enum number:%d is out of range", e.Number())
}
value := e.Descriptor().Values().Get(int(e.Number()))

// Retrieve custom options
Expand Down
6 changes: 6 additions & 0 deletions go/enum/parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,10 @@ func TestGetStringValue(t *testing.T) {
require.NoError(t, err)
require.NotNil(t, got)
require.Equal(t, "ext3", *got)

var invalid apiv2.Format = 42
got, err = GetStringValue(invalid)
require.Error(t, err)
require.EqualError(t, err, "given enum number:42 is out of range")
require.Nil(t, got)
}
Loading